OSDN Git Service

Input: goodix - print values in case of inconsistencies
authorGuido Günther <agx@sigxcpu.org>
Sun, 17 Feb 2019 07:04:43 +0000 (23:04 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Sun, 17 Feb 2019 07:08:09 +0000 (23:08 -0800)
"Invalid config" gives little idea what's wrong. Print the values that
must not be 0 so we know which ones are off.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/goodix.c

index 47b1ced..f57d822 100644 (file)
@@ -693,7 +693,9 @@ static int goodix_configure_dev(struct goodix_ts_data *ts)
        touchscreen_parse_properties(ts->input_dev, true, &ts->prop);
 
        if (!ts->prop.max_x || !ts->prop.max_y || !ts->max_touch_num) {
-               dev_err(&ts->client->dev, "Invalid config, using defaults\n");
+               dev_err(&ts->client->dev,
+                       "Invalid config (%d, %d, %d), using defaults\n",
+                       ts->prop.max_x, ts->prop.max_y, ts->max_touch_num);
                ts->prop.max_x = GOODIX_MAX_WIDTH - 1;
                ts->prop.max_y = GOODIX_MAX_HEIGHT - 1;
                ts->max_touch_num = GOODIX_MAX_CONTACTS;