OSDN Git Service

drm/i915: Remove nop bigjoiner state copy
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 23 Feb 2022 13:13:05 +0000 (15:13 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 25 Feb 2022 17:08:24 +0000 (19:08 +0200)
We just copied over the whole master crtc state, including
cpu_transcoder+has_audio. No need to copy those again.

Also get rid of the unhelpful comment.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220223131315.18016-4-ville.syrjala@linux.intel.com
drivers/gpu/drm/i915/display/intel_display.c

index 666f922..6e4b30a 100644 (file)
@@ -5593,12 +5593,9 @@ copy_bigjoiner_crtc_state_modeset(struct intel_atomic_state *state,
 
        copy_bigjoiner_crtc_state_nomodeset(state, slave_crtc);
 
-       /* Some fixups */
        slave_crtc_state->uapi.mode_changed = master_crtc_state->uapi.mode_changed;
        slave_crtc_state->uapi.connectors_changed = master_crtc_state->uapi.connectors_changed;
        slave_crtc_state->uapi.active_changed = master_crtc_state->uapi.active_changed;
-       slave_crtc_state->cpu_transcoder = master_crtc_state->cpu_transcoder;
-       slave_crtc_state->has_audio = master_crtc_state->has_audio;
 
        return 0;
 }