OSDN Git Service

media: imx: utils: Inline init_mbus_colorimetry() in its caller
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Mon, 6 Apr 2020 16:38:57 +0000 (18:38 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 21 Apr 2020 11:14:03 +0000 (13:14 +0200)
The init_mbus_colorimetry() function is small and used in a single
place. The code becomes easier to follow if it gets inline in its
caller. Do so.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/imx/imx-media-utils.c

index 00a71f0..cf0aba8 100644 (file)
@@ -210,19 +210,6 @@ static const struct imx_media_pixfmt ipu_rgb_formats[] = {
 
 #define NUM_IPU_RGB_FORMATS ARRAY_SIZE(ipu_rgb_formats)
 
-static void init_mbus_colorimetry(struct v4l2_mbus_framefmt *mbus,
-                                 const struct imx_media_pixfmt *fmt)
-{
-       mbus->colorspace = (fmt->cs == IPUV3_COLORSPACE_RGB) ?
-               V4L2_COLORSPACE_SRGB : V4L2_COLORSPACE_SMPTE170M;
-       mbus->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(mbus->colorspace);
-       mbus->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(mbus->colorspace);
-       mbus->quantization =
-               V4L2_MAP_QUANTIZATION_DEFAULT(fmt->cs == IPUV3_COLORSPACE_RGB,
-                                             mbus->colorspace,
-                                             mbus->ycbcr_enc);
-}
-
 static const struct imx_media_pixfmt *find_format(u32 fourcc,
                                                  u32 code,
                                                  enum codespace_sel cs_sel,
@@ -423,7 +410,16 @@ int imx_media_init_mbus_fmt(struct v4l2_mbus_framefmt *mbus,
        }
 
        mbus->code = code;
-       init_mbus_colorimetry(mbus, lcc);
+
+       mbus->colorspace = (lcc->cs == IPUV3_COLORSPACE_RGB) ?
+               V4L2_COLORSPACE_SRGB : V4L2_COLORSPACE_SMPTE170M;
+       mbus->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(mbus->colorspace);
+       mbus->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(mbus->colorspace);
+       mbus->quantization =
+               V4L2_MAP_QUANTIZATION_DEFAULT(lcc->cs == IPUV3_COLORSPACE_RGB,
+                                             mbus->colorspace,
+                                             mbus->ycbcr_enc);
+
        if (cc)
                *cc = lcc;