OSDN Git Service

PCI: dwc: pci-dra7xx: Fix runtime PM imbalance on error
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Wed, 20 May 2020 08:47:56 +0000 (16:47 +0800)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Tue, 7 Jul 2020 10:29:12 +0000 (11:29 +0100)
pm_runtime_get_sync() increments the runtime PM usage counter even
it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Link: https://lore.kernel.org/r/20200520084756.31620-1-dinghao.liu@zju.edu.cn
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
drivers/pci/controller/dwc/pci-dra7xx.c

index 6184ebc..01d821e 100644 (file)
@@ -998,9 +998,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
        return 0;
 
 err_gpio:
-       pm_runtime_put(dev);
-
 err_get_sync:
+       pm_runtime_put(dev);
        pm_runtime_disable(dev);
        dra7xx_pcie_disable_phy(dra7xx);