OSDN Git Service

android/client: Fix crash in tab completion
authorJerzy Kasenberg <jerzy.kasenberg@tieto.com>
Wed, 30 Oct 2013 09:31:12 +0000 (10:31 +0100)
committerJohan Hedberg <johan.hedberg@intel.com>
Wed, 30 Oct 2013 10:06:45 +0000 (12:06 +0200)
When user pressed tab on third or later argument when
first two did not make sense tool crashed.
Now method is checked for NULL before accessing help field.

android/client/tabcompletion.c

index 69af609..cc1a5d3 100644 (file)
@@ -332,7 +332,7 @@ static void param_completion(int argc, const split_arg_t *arg,
        if (args.func != NULL) {
                args.typed = argv[argc - 1];
                args.help = method_help;
-               args.user_help = (void *) method->help;
+               args.user_help = method ? (void *) method->help : NULL;
 
                tab_completion(&args);
        }