OSDN Git Service

Suppress warnings from "git var -l"
authorJonathan Nieder <jrnieder@gmail.com>
Wed, 11 Nov 2009 23:57:36 +0000 (17:57 -0600)
committerJunio C Hamano <gitster@pobox.com>
Fri, 13 Nov 2009 20:16:30 +0000 (12:16 -0800)
For scripts using "git var -l" to read all logical variables at
once, not all per-variable warnings will be relevant.  So suppress
them.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
ident.c
var.c

diff --git a/ident.c b/ident.c
index 99f1c85..26409b2 100644 (file)
--- a/ident.c
+++ b/ident.c
@@ -205,7 +205,7 @@ const char *fmt_ident(const char *name, const char *email,
                if ((warn_on_no_name || error_on_no_name) &&
                    name == git_default_name && env_hint) {
                        fprintf(stderr, env_hint, au_env, co_env);
-                       env_hint = NULL; /* warn only once, for "git var -l" */
+                       env_hint = NULL; /* warn only once */
                }
                if (error_on_no_name)
                        die("empty ident %s <%s> not allowed", name, email);
diff --git a/var.c b/var.c
index 125c0d1..dacbaab 100644 (file)
--- a/var.c
+++ b/var.c
@@ -22,7 +22,7 @@ static void list_vars(void)
 {
        struct git_var *ptr;
        for (ptr = git_vars; ptr->read; ptr++)
-               printf("%s=%s\n", ptr->name, ptr->read(IDENT_WARN_ON_NO_NAME));
+               printf("%s=%s\n", ptr->name, ptr->read(0));
 }
 
 static const char *read_var(const char *var)