OSDN Git Service

eth: sfc: remove remnants of the out-of-tree napi_weight module param
authorJakub Kicinski <kuba@kernel.org>
Thu, 12 May 2022 20:56:03 +0000 (13:56 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 14 May 2022 00:03:09 +0000 (17:03 -0700)
Remove napi_weight statics which are set to 64 and never modified,
remnants of the out-of-tree napi_weight module param.

Acked-by: Edward Cree <ecree.xilinx@gmail.com>
Link: https://lore.kernel.org/r/20220512205603.1536771-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/sfc/efx_channels.c
drivers/net/ethernet/sfc/falcon/efx.c
drivers/net/ethernet/sfc/siena/efx_channels.c

index 79df636..f4919e7 100644 (file)
@@ -46,11 +46,6 @@ module_param(irq_adapt_high_thresh, uint, 0644);
 MODULE_PARM_DESC(irq_adapt_high_thresh,
                 "Threshold score for increasing IRQ moderation");
 
-/* This is the weight assigned to each of the (per-channel) virtual
- * NAPI devices.
- */
-static int napi_weight = 64;
-
 static const struct efx_channel_type efx_default_channel_type;
 
 /*************
@@ -1320,8 +1315,7 @@ void efx_init_napi_channel(struct efx_channel *channel)
        struct efx_nic *efx = channel->efx;
 
        channel->napi_dev = efx->net_dev;
-       netif_napi_add_weight(channel->napi_dev, &channel->napi_str, efx_poll,
-                             napi_weight);
+       netif_napi_add(channel->napi_dev, &channel->napi_str, efx_poll, 64);
 }
 
 void efx_init_napi(struct efx_nic *efx)
index f619ffb..a63f40b 100644 (file)
@@ -112,11 +112,6 @@ module_param(ef4_separate_tx_channels, bool, 0444);
 MODULE_PARM_DESC(ef4_separate_tx_channels,
                 "Use separate channels for TX and RX");
 
-/* This is the weight assigned to each of the (per-channel) virtual
- * NAPI devices.
- */
-static int napi_weight = 64;
-
 /* This is the time (in jiffies) between invocations of the hardware
  * monitor.
  * On Falcon-based NICs, this will:
@@ -2017,8 +2012,7 @@ static void ef4_init_napi_channel(struct ef4_channel *channel)
        struct ef4_nic *efx = channel->efx;
 
        channel->napi_dev = efx->net_dev;
-       netif_napi_add_weight(channel->napi_dev, &channel->napi_str, ef4_poll,
-                             napi_weight);
+       netif_napi_add(channel->napi_dev, &channel->napi_str, ef4_poll, 64);
 }
 
 static void ef4_init_napi(struct ef4_nic *efx)
index 2839187..2465cf4 100644 (file)
@@ -46,11 +46,6 @@ module_param(irq_adapt_high_thresh, uint, 0644);
 MODULE_PARM_DESC(irq_adapt_high_thresh,
                 "Threshold score for increasing IRQ moderation");
 
-/* This is the weight assigned to each of the (per-channel) virtual
- * NAPI devices.
- */
-static int napi_weight = 64;
-
 static const struct efx_channel_type efx_default_channel_type;
 
 /*************
@@ -1324,8 +1319,7 @@ static void efx_init_napi_channel(struct efx_channel *channel)
        struct efx_nic *efx = channel->efx;
 
        channel->napi_dev = efx->net_dev;
-       netif_napi_add_weight(channel->napi_dev, &channel->napi_str, efx_poll,
-                             napi_weight);
+       netif_napi_add(channel->napi_dev, &channel->napi_str, efx_poll, 64);
 }
 
 void efx_siena_init_napi(struct efx_nic *efx)