OSDN Git Service

ALSA: intel_hdmi: Use strlcpy() instead of strncpy()
authorTakashi Iwai <tiwai@suse.de>
Wed, 27 Jun 2018 12:59:00 +0000 (14:59 +0200)
committerTakashi Iwai <tiwai@suse.de>
Wed, 27 Jun 2018 16:11:32 +0000 (18:11 +0200)
hdmi_lpe_audio_probe() copies the pcm name string via strncpy(), but
as a gcc8 warning suggests, it misses a NUL terminator, and unlikely
the expected result.

Use the proper one, strlcpy() instead.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/x86/intel_hdmi_audio.c

index 4ed9d0c..edc9f5a 100644 (file)
@@ -1854,7 +1854,7 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev)
                /* setup private data which can be retrieved when required */
                pcm->private_data = ctx;
                pcm->info_flags = 0;
-               strncpy(pcm->name, card->shortname, strlen(card->shortname));
+               strlcpy(pcm->name, card->shortname, strlen(card->shortname));
                /* setup the ops for playabck */
                snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &had_pcm_ops);