OSDN Git Service

powerpc/watchpoint: Get watchpoint count dynamically while disabling them
authorRavi Bangoria <ravi.bangoria@linux.ibm.com>
Thu, 14 May 2020 11:17:32 +0000 (16:47 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 18 May 2020 14:11:04 +0000 (00:11 +1000)
Instead of disabling only one watchpoint, get num of available
watchpoints dynamically and disable all of them.

Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Reviewed-by: Michael Neuling <mikey@neuling.org>
Link: https://lore.kernel.org/r/20200514111741.97993-8-ravi.bangoria@linux.ibm.com
arch/powerpc/include/asm/hw_breakpoint.h

index 1120c7d..d472b2e 100644 (file)
@@ -78,14 +78,14 @@ extern void ptrace_triggered(struct perf_event *bp,
                        struct perf_sample_data *data, struct pt_regs *regs);
 static inline void hw_breakpoint_disable(void)
 {
-       struct arch_hw_breakpoint brk;
-
-       brk.address = 0;
-       brk.type = 0;
-       brk.len = 0;
-       brk.hw_len = 0;
-       if (ppc_breakpoint_available())
-               __set_breakpoint(0, &brk);
+       int i;
+       struct arch_hw_breakpoint null_brk = {0};
+
+       if (!ppc_breakpoint_available())
+               return;
+
+       for (i = 0; i < nr_wp_slots(); i++)
+               __set_breakpoint(i, &null_brk);
 }
 extern void thread_change_pc(struct task_struct *tsk, struct pt_regs *regs);
 int hw_breakpoint_handler(struct die_args *args);