OSDN Git Service

extcon: max14577: fix handling return value of regmap_irq_get_virq
authorAndrzej Hajda <a.hajda@samsung.com>
Mon, 14 Dec 2015 10:06:02 +0000 (11:06 +0100)
committerChanwoo Choi <cw00.choi@samsung.com>
Tue, 15 Dec 2015 01:02:03 +0000 (10:02 +0900)
The function can return negative values, so its result should
be assigned to signed variable.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/extcon-max14577.c

index 601dbd9..b30ab97 100644 (file)
@@ -692,7 +692,7 @@ static int max14577_muic_probe(struct platform_device *pdev)
        /* Support irq domain for max14577 MUIC device */
        for (i = 0; i < info->muic_irqs_num; i++) {
                struct max14577_muic_irq *muic_irq = &info->muic_irqs[i];
-               unsigned int virq = 0;
+               int virq = 0;
 
                virq = regmap_irq_get_virq(max14577->irq_data, muic_irq->irq);
                if (virq <= 0)