OSDN Git Service

drm: rcar-du: Don't put reference to drm_device in rcar_du_remove()
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tue, 23 Mar 2021 00:09:53 +0000 (02:09 +0200)
committerLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Wed, 28 Jul 2021 13:33:07 +0000 (16:33 +0300)
The reference to the drm_device that was acquired by
devm_drm_dev_alloc() is released automatically by the devres
infrastructure. It must not be released manually, as that causes a
reference underflow..

Fixes: ea6aae151887 ("drm: rcar-du: Embed drm_device in rcar_du_device")
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
drivers/gpu/drm/rcar-du/rcar_du_drv.c

index 9788286..44b18fa 100644 (file)
@@ -556,8 +556,6 @@ static int rcar_du_remove(struct platform_device *pdev)
 
        drm_kms_helper_poll_fini(ddev);
 
-       drm_dev_put(ddev);
-
        return 0;
 }