OSDN Git Service

iwlwifi: acpi: remove unused function iwl_acpi_eval_dsm_func()
authorKalle Valo <kvalo@codeaurora.org>
Thu, 24 Jun 2021 05:29:18 +0000 (08:29 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 24 Jun 2021 16:21:57 +0000 (19:21 +0300)
Stephen reported a warning:

drivers/net/wireless/intel/iwlwifi/fw/acpi.c:720:12: warning: 'iwl_acpi_eval_dsm_func' defined but not used [-Wunused-function]

The warning is correct and the function is not used anywhere, so let's
just remove it.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 7119f02b5d34 ("iwlwifi: mvm: support BIOS enable/disable for 11ax in Russia")
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Acked-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210624052918.4946-1-kvalo@codeaurora.org
drivers/net/wireless/intel/iwlwifi/fw/acpi.c

index 8cf7bc3..34933f1 100644 (file)
@@ -717,42 +717,6 @@ int iwl_sar_geo_init(struct iwl_fw_runtime *fwrt,
 }
 IWL_EXPORT_SYMBOL(iwl_sar_geo_init);
 
-static u32 iwl_acpi_eval_dsm_func(struct device *dev, enum iwl_dsm_funcs_rev_0 eval_func)
-{
-       union acpi_object *obj;
-       u32 ret;
-
-       obj = iwl_acpi_get_dsm_object(dev, 0,
-                                     eval_func, NULL,
-                                     &iwl_guid);
-
-       if (IS_ERR(obj)) {
-               IWL_DEBUG_DEV_RADIO(dev,
-                                   "ACPI: DSM func '%d': Got Error in obj = %ld\n",
-                                   eval_func,
-                                   PTR_ERR(obj));
-               return 0;
-       }
-
-       if (obj->type != ACPI_TYPE_INTEGER) {
-               IWL_DEBUG_DEV_RADIO(dev,
-                                   "ACPI: DSM func '%d' did not return a valid object, type=%d\n",
-                                   eval_func,
-                                   obj->type);
-               ret = 0;
-               goto out;
-       }
-
-       ret = obj->integer.value;
-       IWL_DEBUG_DEV_RADIO(dev,
-                           "ACPI: DSM method evaluated: func='%d', ret=%d\n",
-                           eval_func,
-                           ret);
-out:
-       ACPI_FREE(obj);
-       return ret;
-}
-
 __le32 iwl_acpi_get_lari_config_bitmap(struct iwl_fw_runtime *fwrt)
 {
        int ret;