OSDN Git Service

drm/stm: ltdc: fix deferred endpoint management
authorPhilippe CORNU <philippe.cornu@st.com>
Tue, 17 Apr 2018 11:34:41 +0000 (13:34 +0200)
committerPhilippe Cornu <philippe.cornu@st.com>
Fri, 27 Apr 2018 08:39:45 +0000 (10:39 +0200)
When a driver related to one of the endpoints is deferred
due to probe dependencies (i2c, spi...) but the other one
is ready, ltdc probe continues and the deferred driver
will never be probed again.

The fix consists in waiting for all deferred endpoints before
continuing the ltdc probe.

Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
Reviewed-by: Yannick Fertré <yannick.fertre@st.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180417113441.8214-1-philippe.cornu@st.com
drivers/gpu/drm/stm/ltdc.c

index e3121d9..014cef8 100644 (file)
@@ -987,14 +987,13 @@ int ltdc_load(struct drm_device *ddev)
                                                  &bridge[i]);
 
                /*
-                * If at least one endpoint is ready, continue probing,
-                * else if at least one endpoint is -EPROBE_DEFER and
-                * there is no previous ready endpoints, defer probing.
+                * If at least one endpoint is -EPROBE_DEFER, defer probing,
+                * else if at least one endpoint is ready, continue probing.
                 */
-               if (!ret)
+               if (ret == -EPROBE_DEFER)
+                       return ret;
+               else if (!ret)
                        endpoint_not_ready = 0;
-               else if (ret == -EPROBE_DEFER && endpoint_not_ready)
-                       endpoint_not_ready = -EPROBE_DEFER;
        }
 
        if (endpoint_not_ready)