OSDN Git Service

devlink: Delete not-used single parameter notification APIs
authorLeon Romanovsky <leonro@nvidia.com>
Tue, 14 Sep 2021 12:58:29 +0000 (15:58 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 15 Sep 2021 15:12:55 +0000 (16:12 +0100)
There is no need in specific devlink_param_*publish(), because same
output can be achieved by using devlink_params_*publish() in correct
places.

Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/devlink.h
net/core/devlink.c

index 154cf0d..cd89b2d 100644 (file)
@@ -1653,10 +1653,6 @@ void devlink_param_unregister(struct devlink *devlink,
                              const struct devlink_param *param);
 void devlink_params_publish(struct devlink *devlink);
 void devlink_params_unpublish(struct devlink *devlink);
-void devlink_param_publish(struct devlink *devlink,
-                          const struct devlink_param *param);
-void devlink_param_unpublish(struct devlink *devlink,
-                            const struct devlink_param *param);
 int devlink_port_params_register(struct devlink_port *devlink_port,
                                 const struct devlink_param *params,
                                 size_t params_count);
index a856ae4..f30121f 100644 (file)
@@ -10122,54 +10122,6 @@ void devlink_params_unpublish(struct devlink *devlink)
 EXPORT_SYMBOL_GPL(devlink_params_unpublish);
 
 /**
- * devlink_param_publish - publish one configuration parameter
- *
- * @devlink: devlink
- * @param: one configuration parameter
- *
- * Publish previously registered configuration parameter.
- */
-void devlink_param_publish(struct devlink *devlink,
-                          const struct devlink_param *param)
-{
-       struct devlink_param_item *param_item;
-
-       list_for_each_entry(param_item, &devlink->param_list, list) {
-               if (param_item->param != param || param_item->published)
-                       continue;
-               param_item->published = true;
-               devlink_param_notify(devlink, 0, param_item,
-                                    DEVLINK_CMD_PARAM_NEW);
-               break;
-       }
-}
-EXPORT_SYMBOL_GPL(devlink_param_publish);
-
-/**
- * devlink_param_unpublish - unpublish one configuration parameter
- *
- * @devlink: devlink
- * @param: one configuration parameter
- *
- * Unpublish previously registered configuration parameter.
- */
-void devlink_param_unpublish(struct devlink *devlink,
-                            const struct devlink_param *param)
-{
-       struct devlink_param_item *param_item;
-
-       list_for_each_entry(param_item, &devlink->param_list, list) {
-               if (param_item->param != param || !param_item->published)
-                       continue;
-               param_item->published = false;
-               devlink_param_notify(devlink, 0, param_item,
-                                    DEVLINK_CMD_PARAM_DEL);
-               break;
-       }
-}
-EXPORT_SYMBOL_GPL(devlink_param_unpublish);
-
-/**
  *     devlink_port_params_register - register port configuration parameters
  *
  *     @devlink_port: devlink port