pktgen: Remove redundant clone_skb override

When the netif_receive xmit_mode is set, a line is supposed to set
clone_skb to a default 0 value. This line is made redundant due to a
preceding line that checks if clone_skb is more than zero and returns
-ENOTSUPP.

Overriding clone_skb to 0 does not make any difference to the behavior
because if it was positive we return error. So it can be either 0 or
negative, and in both cases the behavior is the same.

Remove redundant line that sets clone_skb to zero.

Signed-off-by: Nick Richardson <richardsonnick@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 7e258d2..314f97a 100644 (file)
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -1190,11 +1190,6 @@ static ssize_t pktgen_if_write(struct file *file,
                         * pktgen_xmit() is called
                         */
                        pkt_dev->last_ok = 1;
-
-                       /* override clone_skb if user passed default value
-                        * at module loading time
-                        */
-                       pkt_dev->clone_skb = 0;
                } else if (strcmp(f, "queue_xmit") == 0) {
                        pkt_dev->xmit_mode = M_QUEUE_XMIT;
                        pkt_dev->last_ok = 1;