OSDN Git Service

iwlwifi: Fix -EIO error code that is never returned
authorColin Ian King <colin.king@canonical.com>
Tue, 7 Sep 2021 10:46:58 +0000 (11:46 +0100)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 18 Feb 2022 08:40:56 +0000 (10:40 +0200)
Currently the error -EIO is being assinged to variable ret when
the READY_BIT is not set but the function iwlagn_mac_start returns
0 rather than ret. Fix this by returning ret instead of 0.

Addresses-Coverity: ("Unused value")
Fixes: 7335613ae27a ("iwlwifi: move all mac80211 related functions to one place")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210907104658.14706-1-colin.king@canonical.com
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/dvm/mac80211.c

index 754876c..e8bd4f0 100644 (file)
@@ -299,7 +299,7 @@ static int iwlagn_mac_start(struct ieee80211_hw *hw)
 
        priv->is_open = 1;
        IWL_DEBUG_MAC80211(priv, "leave\n");
-       return 0;
+       return ret;
 }
 
 static void iwlagn_mac_stop(struct ieee80211_hw *hw)