OSDN Git Service

drm/amd/pp: remove redundant pointer internal_buf
authorColin Ian King <colin.king@canonical.com>
Tue, 13 Mar 2018 13:22:17 +0000 (13:22 +0000)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 14 Mar 2018 21:01:17 +0000 (16:01 -0500)
The pointer internal_buf is assigned a value but the pointer is never
read, hence it is redundant and can be removed.

Cleans up clang warning:
drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/smu7_smumgr.c:630:2:
warning: Value stored to 'internal_buf' is never read

Reviewed-by: Rex Zhu <Rex.Zhu@amd.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c

index 7394bb4..dcb151c 100644 (file)
@@ -585,7 +585,6 @@ int smu7_setup_pwr_virus(struct pp_hwmgr *hwmgr)
 int smu7_init(struct pp_hwmgr *hwmgr)
 {
        struct smu7_smumgr *smu_data;
-       uint8_t *internal_buf;
        uint64_t mc_addr = 0;
        int r;
        /* Allocate memory for backend private data */
@@ -627,7 +626,6 @@ int smu7_init(struct pp_hwmgr *hwmgr)
                                        &smu_data->header_buffer.kaddr);
                return -EINVAL;
        }
-       internal_buf = smu_data->smu_buffer.kaddr;
        smu_data->smu_buffer.mc_addr = mc_addr;
 
        if (smum_is_hw_avfs_present(hwmgr))