OSDN Git Service

fpga: bridge: Replace open-coded list_for_each + list_entry
authorMoritz Fischer <mdf@kernel.org>
Fri, 10 Mar 2017 20:47:11 +0000 (12:47 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Mar 2017 06:10:48 +0000 (15:10 +0900)
Replaces open-coded list_for_each() + list_entry() with macro
list_for_each_entry()

Signed-off-by: Moritz Fischer <mdf@kernel.org>
Cc: linux-fpga@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Acked-by: Alan Tull <atull@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/fpga/fpga-bridge.c

index e04a899..9651aa5 100644 (file)
@@ -146,11 +146,9 @@ EXPORT_SYMBOL_GPL(fpga_bridge_put);
 int fpga_bridges_enable(struct list_head *bridge_list)
 {
        struct fpga_bridge *bridge;
-       struct list_head *node;
        int ret;
 
-       list_for_each(node, bridge_list) {
-               bridge = list_entry(node, struct fpga_bridge, node);
+       list_for_each_entry(bridge, bridge_list, node) {
                ret = fpga_bridge_enable(bridge);
                if (ret)
                        return ret;
@@ -172,11 +170,9 @@ EXPORT_SYMBOL_GPL(fpga_bridges_enable);
 int fpga_bridges_disable(struct list_head *bridge_list)
 {
        struct fpga_bridge *bridge;
-       struct list_head *node;
        int ret;
 
-       list_for_each(node, bridge_list) {
-               bridge = list_entry(node, struct fpga_bridge, node);
+       list_for_each_entry(bridge, bridge_list, node) {
                ret = fpga_bridge_disable(bridge);
                if (ret)
                        return ret;
@@ -196,13 +192,10 @@ EXPORT_SYMBOL_GPL(fpga_bridges_disable);
  */
 void fpga_bridges_put(struct list_head *bridge_list)
 {
-       struct fpga_bridge *bridge;
-       struct list_head *node, *next;
+       struct fpga_bridge *bridge, *next;
        unsigned long flags;
 
-       list_for_each_safe(node, next, bridge_list) {
-               bridge = list_entry(node, struct fpga_bridge, node);
-
+       list_for_each_entry_safe(bridge, next, bridge_list, node) {
                fpga_bridge_put(bridge);
 
                spin_lock_irqsave(&bridge_list_lock, flags);