OSDN Git Service
(root)
/
qmiga
/
qemu.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a31ca68
)
aio-posix: remove confusing QLIST_SAFE_REMOVE()
author
Stefan Hajnoczi
<stefanha@redhat.com>
Mon, 24 Feb 2020 10:34:06 +0000
(10:34 +0000)
committer
Stefan Hajnoczi
<stefanha@redhat.com>
Mon, 9 Mar 2020 16:39:20 +0000
(16:39 +0000)
QLIST_SAFE_REMOVE() is confusing here because the node must be on the
list. We actually just wanted to clear the linked list pointers when
removing it from the list. QLIST_REMOVE() now does this, so switch to
it.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Link:
https://lore.kernel.org/r/20200224103406.1894923-3-stefanha@redhat.com
Message-Id: <
20200224103406
.
1894923
-3-stefanha@redhat.com>
util/aio-posix.c
patch
|
blob
|
history
diff --git
a/util/aio-posix.c
b/util/aio-posix.c
index
9e1befc
..
b339aab
100644
(file)
--- a/
util/aio-posix.c
+++ b/
util/aio-posix.c
@@
-493,7
+493,7
@@
static bool aio_dispatch_ready_handlers(AioContext *ctx,
AioHandler *node;
while ((node = QLIST_FIRST(ready_list))) {
- QLIST_
SAFE_
REMOVE(node, node_ready);
+ QLIST_REMOVE(node, node_ready);
progress = aio_dispatch_handler(ctx, node) || progress;
}