OSDN Git Service

sgi-xp: remove h from printk format specifier
authorTom Rix <trix@redhat.com>
Sat, 23 Jan 2021 16:00:03 +0000 (08:00 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 26 Jan 2021 18:36:02 +0000 (19:36 +0100)
This change fixes the checkpatch warning described in this commit
commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
  unnecessary %h[xudi] and %hh[xudi]")

Standard integer promotion is already done and %hx and %hhx is useless
so do not encourage the use of %hh[xudi] or %h[xudi].

Reviewed-By: Steve Wahl <steve.wahl@hpe.com>
Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20210123160003.1777766-1-trix@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/sgi-xp/xpnet.c

index 23837d0..2508f83 100644 (file)
@@ -208,7 +208,7 @@ xpnet_receive(short partid, int channel, struct xpnet_message *msg)
        } else {
                dst = (void *)((u64)skb->data & ~(L1_CACHE_BYTES - 1));
                dev_dbg(xpnet, "transferring buffer to the skb->data area;\n\t"
-                       "xp_remote_memcpy(0x%p, 0x%p, %hu)\n", dst,
+                       "xp_remote_memcpy(0x%p, 0x%p, %u)\n", dst,
                                          (void *)msg->buf_pa, msg->size);
 
                ret = xp_remote_memcpy(xp_pa(dst), msg->buf_pa, msg->size);
@@ -218,7 +218,7 @@ xpnet_receive(short partid, int channel, struct xpnet_message *msg)
                         * !!! appears in_use and we can't just call
                         * !!! dev_kfree_skb.
                         */
-                       dev_err(xpnet, "xp_remote_memcpy(0x%p, 0x%p, 0x%hx) "
+                       dev_err(xpnet, "xp_remote_memcpy(0x%p, 0x%p, 0x%x) "
                                "returned error=0x%x\n", dst,
                                (void *)msg->buf_pa, msg->size, ret);