OSDN Git Service

scsi: Document intentional fall through in scsi_req_length()
authorMarkus Armbruster <armbru@redhat.com>
Fri, 16 May 2014 15:44:05 +0000 (17:44 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 16 May 2014 15:52:14 +0000 (17:52 +0200)
For clarity, and to hush up Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/scsi/scsi-bus.c

index ae921a6..26770fb 100644 (file)
@@ -938,6 +938,7 @@ static int scsi_req_length(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf)
         if (cmd->xfer == 0) {
             cmd->xfer = 256;
         }
+        /* fall through */
     case WRITE_10:
     case WRITE_VERIFY_10:
     case WRITE_12:
@@ -952,6 +953,7 @@ static int scsi_req_length(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf)
         if (cmd->xfer == 0) {
             cmd->xfer = 256;
         }
+        /* fall through */
     case READ_10:
     case RECOVER_BUFFERED_DATA:
     case READ_12: