OSDN Git Service

hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()
authorweiyongjun \(A\) <weiyongjun1@huawei.com>
Wed, 17 Jan 2018 11:40:34 +0000 (11:40 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 25 Jan 2018 14:10:31 +0000 (01:10 +1100)
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/bcm2835-rng.c

index 25e5631..7a84cec 100644 (file)
@@ -158,10 +158,8 @@ static int bcm2835_rng_probe(struct platform_device *pdev)
 
        /* map peripheral */
        priv->base = devm_ioremap_resource(dev, r);
-       if (IS_ERR(priv->base)) {
-               dev_err(dev, "failed to remap rng regs");
+       if (IS_ERR(priv->base))
                return PTR_ERR(priv->base);
-       }
 
        /* Clock is optional on most platforms */
        priv->clk = devm_clk_get(dev, NULL);