OSDN Git Service

iio temperature/mlx90632: silence a static checker warning
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 22 Feb 2018 09:14:53 +0000 (12:14 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 24 Feb 2018 13:32:05 +0000 (13:32 +0000)
This shouldn't affect runtime at all, but Smatch complains that we
should check if mlx90632_read_ambient_raw() otherwise we
"ambient_new_raw" can be uninitialized.

    drivers/iio/temperature/mlx90632.c:509 mlx90632_calc_ambient_dsp105()
    error: uninitialized symbol 'ambient_new_raw'.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Crt Mori <cmo@melexis.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/temperature/mlx90632.c

index d695ab9..9851311 100644 (file)
@@ -506,6 +506,8 @@ static int mlx90632_calc_ambient_dsp105(struct mlx90632_data *data, int *val)
 
        ret = mlx90632_read_ambient_raw(data->regmap, &ambient_new_raw,
                                        &ambient_old_raw);
+       if (ret < 0)
+               return ret;
        *val = mlx90632_calc_temp_ambient(ambient_new_raw, ambient_old_raw,
                                          PT, PR, PG, PO, Gb);
        return ret;