OSDN Git Service

openvswitch: Optimize updating for OvS flow_stats.
authorTonghao Zhang <xiangxia.m.yue@gmail.com>
Tue, 18 Jul 2017 06:28:05 +0000 (23:28 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 19 Jul 2017 20:49:39 +0000 (13:49 -0700)
In the ovs_flow_stats_update(), we only use the node
var to alloc flow_stats struct. But this is not a
common case, it is unnecessary to call the numa_node_id()
everytime. This patch is not a bugfix, but there maybe
a small increase.

Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/openvswitch/flow.c

index 597d96f..6ef51e7 100644 (file)
@@ -72,7 +72,6 @@ void ovs_flow_stats_update(struct sw_flow *flow, __be16 tcp_flags,
                           const struct sk_buff *skb)
 {
        struct flow_stats *stats;
-       int node = numa_node_id();
        int cpu = smp_processor_id();
        int len = skb->len + (skb_vlan_tag_present(skb) ? VLAN_HLEN : 0);
 
@@ -108,7 +107,7 @@ void ovs_flow_stats_update(struct sw_flow *flow, __be16 tcp_flags,
                                                              __GFP_THISNODE |
                                                              __GFP_NOWARN |
                                                              __GFP_NOMEMALLOC,
-                                                             node);
+                                                             numa_node_id());
                                if (likely(new_stats)) {
                                        new_stats->used = jiffies;
                                        new_stats->packet_count = 1;