OSDN Git Service

soundwire: intel_init: remove useless interrupt enablement in interrupt thread
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 11 Nov 2022 04:26:46 +0000 (12:26 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 23 Nov 2022 15:32:01 +0000 (15:32 +0000)
When the code reaches the SoundWire interrupt thread handling, the
interrupt was enabled already, and there is no code that disables it
-> this is a no-op sequence.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Acked-By: Vinod Koul <vkoul@kernel.org>
Link: https://lore.kernel.org/r/20221111042653.45520-2-yung-chuan.liao@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/soundwire/intel_init.c

index d091513..8bd95c9 100644 (file)
@@ -157,7 +157,6 @@ irqreturn_t sdw_intel_thread(int irq, void *dev_id)
        list_for_each_entry(link, &ctx->link_list, list)
                sdw_cdns_irq(irq, link->cdns);
 
-       sdw_intel_enable_irq(ctx->mmio_base, true);
        return IRQ_HANDLED;
 }
 EXPORT_SYMBOL_NS(sdw_intel_thread, SOUNDWIRE_INTEL_INIT);