Don't include the Donate menu item in secure mode, as this is a security risk.

Fixes #1419.

diff --git a/source/gui/__init__.py b/source/gui/__init__.py
index d1ee0f2..703f5c4 100644 (file)
--- a/source/gui/__init__.py
+++ b/source/gui/__init__.py
@@ -338,9 +338,10 @@ class SysTrayIcon(wx.TaskBarIcon):
                if not globalVars.appArgs.secure:\r
                        item = self.menu.Append(wx.ID_SAVE, _("&Save configuration"), _("Write the current configuration to nvda.ini"))\r
                        self.Bind(wx.EVT_MENU, frame.onSaveConfigurationCommand, item)\r
-               self.menu.AppendSeparator()\r
-               item = self.menu.Append(wx.ID_ANY, _("Donate"))\r
-               self.Bind(wx.EVT_MENU, lambda evt: os.startfile("http://www.nvaccess.org/wiki/Donate"), item)\r
+               if not globalVars.appArgs.secure:\r
+                       self.menu.AppendSeparator()\r
+                       item = self.menu.Append(wx.ID_ANY, _("Donate"))\r
+                       self.Bind(wx.EVT_MENU, lambda evt: os.startfile("http://www.nvaccess.org/wiki/Donate"), item)\r
                self.menu.AppendSeparator()\r
                item = self.menu.Append(wx.ID_EXIT, _("E&xit"),_("Exit NVDA"))\r
                self.Bind(wx.EVT_MENU, frame.onExitCommand, item)\r

diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t
index e0ced1c..dffa36c 100644 (file)
--- a/user_docs/en/changes.t2t
+++ b/user_docs/en/changes.t2t
@@ -12,6 +12,7 @@
 == Bug Fixes ==\r
 - Collapsing combo boxes in a virtual buffer when focus mode has been forced with NVDA+space no longer auto-switches back to browse mode. (#1386)\r
 - In Gecko (e.g. Firefox) and MSHTML (e.g. Internet Explorer) documents, NVDA now correctly renders certain text on the same line which was previously rendered on separate lines. (#1378)\r
+- The Donate item in the NVDA menu is now disabled when running on the logon, UAC and other secure Windows screens, as this is a security risk. (#1419)\r
 \r
 \r
 == Changes for Developers ==\r