OSDN Git Service

net/mlx5: SF, silence an uninitialized variable warning
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 27 Nov 2021 14:19:53 +0000 (17:19 +0300)
committerSaeed Mahameed <saeedm@nvidia.com>
Fri, 3 Dec 2021 00:53:09 +0000 (16:53 -0800)
This code sometimes calls mlx5_sf_hw_table_hwc_init() when "ext_base_id"
is uninitialized.  It's not used on that path, but it generates a static
checker warning to pass uninitialized variables to another function.
It may also generate runtime UBSan  warnings depending on if the
mlx5_sf_hw_table_hwc_init() function is inlined or not.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/sf/hw_table.c

index 252d601..17aa348 100644 (file)
@@ -247,7 +247,7 @@ int mlx5_sf_hw_table_init(struct mlx5_core_dev *dev)
 {
        struct mlx5_sf_hw_table *table;
        u16 max_ext_fn = 0;
-       u16 ext_base_id;
+       u16 ext_base_id = 0;
        u16 max_fn = 0;
        u16 base_id;
        int err;