OSDN Git Service

NFC: Dereference LLCP bind socket address after checking for it to be NULL
authorSamuel Ortiz <sameo@linux.intel.com>
Fri, 29 Jun 2012 10:03:55 +0000 (12:03 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 9 Jul 2012 20:42:22 +0000 (16:42 -0400)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
net/nfc/llcp/sock.c

index e5d8014..6152d05 100644 (file)
@@ -78,11 +78,11 @@ static int llcp_sock_bind(struct socket *sock, struct sockaddr *addr, int alen)
        struct sockaddr_nfc_llcp llcp_addr;
        int len, ret = 0;
 
-       pr_debug("sk %p addr %p family %d\n", sk, addr, addr->sa_family);
-
        if (!addr || addr->sa_family != AF_NFC)
                return -EINVAL;
 
+       pr_debug("sk %p addr %p family %d\n", sk, addr, addr->sa_family);
+
        memset(&llcp_addr, 0, sizeof(llcp_addr));
        len = min_t(unsigned int, sizeof(llcp_addr), alen);
        memcpy(&llcp_addr, addr, len);