use escapeshellarg() instead of esc_cmd(), because the $editor variable can contain %s

see #822

diff --git a/php/utils.php b/php/utils.php
index 23f6d5e..d1713b5 100644 (file)
--- a/php/utils.php
+++ b/php/utils.php
@@ -274,7 +274,7 @@ function launch_editor_for_input( $input, $title = 'WP-CLI' ) {
                        $editor = 'vi';
        }
 
-       \WP_CLI::launch( \WP_CLI\Utils\esc_cmd( "$editor %s", $tmpfile ) );
+       \WP_CLI::launch( "$editor " . escapeshellarg( $tmpfile ) );
 
        $output = file_get_contents( $tmpfile );