OSDN Git Service

net: hns3: hns3:fix a bug about statistic counter in reset process
authorqumingguang <qumingguang@huawei.com>
Thu, 2 Nov 2017 12:45:23 +0000 (20:45 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 2 Nov 2017 12:28:36 +0000 (21:28 +0900)
All member of Struct hdev->hw_stats is initialized to 0 as hdev is
allocated by devm_kzalloc. But in reset process, hdev will not be
allocated again, so need clear hdev->hw_stats in reset process, otherwise
the statistic will be wrong after reset. This patch set all of the
statistic counters to zero after reset.

Signed-off-by: qumingguang <qumingguang@huawei.com>
Signed-off-by: Lipeng <lipeng321@huawei.com>
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

index 699983a..c6ba890 100644 (file)
@@ -4836,6 +4836,11 @@ err_hclge_dev:
        return ret;
 }
 
+static void hclge_stats_clear(struct hclge_dev *hdev)
+{
+       memset(&hdev->hw_stats, 0, sizeof(hdev->hw_stats));
+}
+
 static int hclge_reset_ae_dev(struct hnae3_ae_dev *ae_dev)
 {
        struct hclge_dev *hdev = ae_dev->priv;
@@ -4844,6 +4849,8 @@ static int hclge_reset_ae_dev(struct hnae3_ae_dev *ae_dev)
 
        set_bit(HCLGE_STATE_DOWN, &hdev->state);
 
+       hclge_stats_clear(hdev);
+
        ret = hclge_cmd_init(hdev);
        if (ret) {
                dev_err(&pdev->dev, "Cmd queue init failed\n");