OSDN Git Service

drivers: misc: ti-st: fix debugfs creation error handling
authorGigi Joseph <gigi.joseph@gmail.com>
Fri, 9 Jan 2015 03:47:51 +0000 (03:47 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 12 Jan 2015 13:04:11 +0000 (05:04 -0800)
In case the debugfs creation fails the whole init process was failing.
There is no need to do this as the shared transport can work without it.
Fix it so it just reports the failure and continue.

Signed-off-by: Eyal Reizer <eyalr@ti.com>
Signed-off-by: Gigi Joseph <gigi.joseph@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/ti-st/st_kim.c

index f2c1071..878956a 100644 (file)
@@ -836,8 +836,7 @@ static int kim_probe(struct platform_device *pdev)
        kim_debugfs_dir = debugfs_create_dir("ti-st", NULL);
        if (!kim_debugfs_dir) {
                pr_err(" debugfs entries creation failed ");
-               err = -EIO;
-               goto err_debugfs_dir;
+               return 0;
        }
 
        debugfs_create_file("version", S_IRUGO, kim_debugfs_dir,
@@ -846,9 +845,6 @@ static int kim_probe(struct platform_device *pdev)
                                kim_gdata, &list_debugfs_fops);
        return 0;
 
-err_debugfs_dir:
-       sysfs_remove_group(&pdev->dev.kobj, &uim_attr_grp);
-
 err_sysfs_group:
        st_core_exit(kim_gdata->core_data);