OSDN Git Service

devlink: Make port index data type as unsigned int
authorParav Pandit <parav@mellanox.com>
Fri, 30 Aug 2019 10:39:44 +0000 (05:39 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sun, 1 Sep 2019 06:46:13 +0000 (23:46 -0700)
Devlink port index attribute is returned to users as u32 through
netlink response.
Change index data type from 'unsigned' to 'unsigned int' to avoid
below checkpatch.pl warning.

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
81: FILE: include/net/devlink.h:81:
+       unsigned index;

Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/devlink.h
net/core/devlink.c

index 7f43c48..13523b0 100644 (file)
@@ -75,7 +75,7 @@ struct devlink_port {
        struct list_head list;
        struct list_head param_list;
        struct devlink *devlink;
-       unsigned index;
+       unsigned int index;
        bool registered;
        spinlock_t type_lock; /* Protects type and type_dev
                               * pointer consistency.
index 650f363..b709132 100644 (file)
@@ -136,7 +136,7 @@ static struct devlink *devlink_get_from_info(struct genl_info *info)
 }
 
 static struct devlink_port *devlink_port_get_by_index(struct devlink *devlink,
-                                                     int port_index)
+                                                     unsigned int port_index)
 {
        struct devlink_port *devlink_port;
 
@@ -147,7 +147,8 @@ static struct devlink_port *devlink_port_get_by_index(struct devlink *devlink,
        return NULL;
 }
 
-static bool devlink_port_index_exists(struct devlink *devlink, int port_index)
+static bool devlink_port_index_exists(struct devlink *devlink,
+                                     unsigned int port_index)
 {
        return devlink_port_get_by_index(devlink, port_index);
 }