OSDN Git Service

mv64361: Remove extra break from a switch case
authorBALATON Zoltan <balaton@eik.bme.hu>
Mon, 12 Jul 2021 13:11:01 +0000 (15:11 +0200)
committerDavid Gibson <david@gibson.dropbear.id.au>
Tue, 13 Jul 2021 00:12:17 +0000 (10:12 +1000)
The switch case of writing PCI 1 IO base address had an extra break
statement that made part of the code unreachable. This did not cause a
problem as guests ususally leave this register at its default value.

Fixes: dcdf98a9015 ("Add emulation of Marvell MV64361 PPC system
       controller")
Reported-by: Coverity (CID 1458135)
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: <20210712131259.B705B7456E3@zero.eik.bme.hu>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/pci-host/mv64361.c

index 20510d8..92b0f5d 100644 (file)
@@ -687,7 +687,6 @@ static void mv64361_write(void *opaque, hwaddr addr, uint64_t val,
     case MV64340_PCI_1_IO_BASE_ADDR:
         s->pci[1].io_base = val & 0x30fffffULL;
         warn_swap_bit(val);
-        break;
         if (!(s->cpu_conf & BIT(27))) {
             s->pci[1].remap[4] = (val & 0xffffULL) << 16;
         }