OSDN Git Service

Staging: pi433: check error after kthread_run()
authorJoseph Wright <rjosephwright@gmail.com>
Sun, 16 Jul 2017 14:48:58 +0000 (14:48 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Jul 2017 23:57:26 +0000 (16:57 -0700)
Error should be checked with IS_ERR after calling kthread_run()
instead of comparing the returned pointer to an int.

Found by sparse warning:

incompatible types for operation (<)
    left side has type struct task_struct *tx_task_struct
    right side has type int

Signed-off-by: Joseph Wright <rjosephwright@gmail.com>
Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de>
Tested-by: Marcus Wolf <linux@wolf-entwicklungen.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/pi433/pi433_if.c

index f886bed..ce76a9e 100644 (file)
@@ -1152,7 +1152,7 @@ static int pi433_probe(struct spi_device *spi)
        device->tx_task_struct = kthread_run(pi433_tx_thread,
                                             device,
                                             "pi433_tx_task");
-       if (device->tx_task_struct < 0)
+       if (IS_ERR(device->tx_task_struct))
        {
                dev_dbg(device->dev, "start of send thread failed");
                goto send_thread_failed;