OSDN Git Service

RDMA/iwpm: Delete an error message for a failed memory allocation in iwpm_create_nlmsg()
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 27 Jan 2018 20:48:01 +0000 (21:48 +0100)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 28 Feb 2018 20:57:39 +0000 (13:57 -0700)
Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/iwpm_util.c

index 81528f6..9821ae9 100644 (file)
@@ -439,10 +439,9 @@ struct sk_buff *iwpm_create_nlmsg(u32 nl_op, struct nlmsghdr **nlh,
        struct sk_buff *skb = NULL;
 
        skb = dev_alloc_skb(IWPM_MSG_SIZE);
-       if (!skb) {
-               pr_err("%s Unable to allocate skb\n", __func__);
+       if (!skb)
                goto create_nlmsg_exit;
-       }
+
        if (!(ibnl_put_msg(skb, nlh, 0, 0, nl_client, nl_op,
                           NLM_F_REQUEST))) {
                pr_warn("%s: Unable to put the nlmsg header\n", __func__);