OSDN Git Service

xhci: ext-caps: Use software node API with the properties
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>
Thu, 4 Feb 2021 14:17:11 +0000 (17:17 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Feb 2021 09:08:19 +0000 (10:08 +0100)
This replaces the platform_device_add_properties() call with
the safer device_create_managed_software_node() that does
exactly the same, but can also guarantee that the lifetime
of the node that is created for the device is tied to the
lifetime of device itself.

Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20210204141711.53775-7-heikki.krogerus@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-ext-caps.c

index 3351d07..7a4c2c4 100644 (file)
@@ -54,7 +54,8 @@ static int xhci_create_intel_xhci_sw_pdev(struct xhci_hcd *xhci, u32 cap_offset)
        }
 
        if (pci->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI) {
-               ret = platform_device_add_properties(pdev, role_switch_props);
+               ret = device_create_managed_software_node(&pdev->dev, role_switch_props,
+                                                         NULL);
                if (ret) {
                        dev_err(dev, "failed to register device properties\n");
                        platform_device_put(pdev);