OSDN Git Service

can: tcan4x5x: tcan4x5x_can_remove(): fix order of deregistration
authorMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 10 Aug 2020 20:23:49 +0000 (22:23 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Sun, 15 Nov 2020 17:24:36 +0000 (18:24 +0100)
Change the order in tcan4x5x_can_remove() to be the exact inverse of
tcan4x5x_can_probe(). First m_can_class_unregister(), then power down the
device.

Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
Cc: Dan Murphy <dmurphy@ti.com>
Link: http://lore.kernel.org/r/20201019154233.1262589-10-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/m_can/tcan4x5x.c

index f058bd9..4fdb712 100644 (file)
@@ -527,10 +527,10 @@ static int tcan4x5x_can_remove(struct spi_device *spi)
 {
        struct tcan4x5x_priv *priv = spi_get_drvdata(spi);
 
-       tcan4x5x_power_enable(priv->power, 0);
-
        m_can_class_unregister(priv->mcan_dev);
 
+       tcan4x5x_power_enable(priv->power, 0);
+
        return 0;
 }