OSDN Git Service

mlx5: Remove call to ida_pre_get
authorMatthew Wilcox <mawilcox@microsoft.com>
Thu, 15 Mar 2018 02:57:24 +0000 (19:57 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 Mar 2018 14:46:01 +0000 (10:46 -0400)
The mlx5 driver calls ida_pre_get() in a loop for no readily apparent
reason.  The driver uses ida_simple_get() which will call ida_pre_get()
by itself and there's no need to use ida_pre_get() unless using
ida_get_new().

Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/fs_core.c

index 10e1638..3ba07c7 100644 (file)
@@ -1647,7 +1647,6 @@ try_add_to_existing_fg(struct mlx5_flow_table *ft,
 
        list_for_each_entry(iter, match_head, list) {
                nested_down_read_ref_node(&iter->g->node, FS_LOCK_PARENT);
-               ida_pre_get(&iter->g->fte_allocator, GFP_KERNEL);
        }
 
 search_again_locked: