OSDN Git Service

RDMA/mlx5: Avoid setting redundant NULL for XRC QPs
authorLeon Romanovsky <leonro@mellanox.com>
Mon, 27 Apr 2020 15:46:05 +0000 (18:46 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 28 Apr 2020 23:42:21 +0000 (20:42 -0300)
There is no need to set NULL in recv_cq and send_cq, they are already
set to NULL by the IB/core logic.

Link: https://lore.kernel.org/r/20200427154636.381474-6-leon@kernel.org
Reviewed-by: Maor Gottlieb <maorg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/mlx5/qp.c

index 07df470..86933a2 100644 (file)
@@ -2771,14 +2771,8 @@ struct ib_qp *mlx5_ib_create_qp(struct ib_pd *pd,
                }
        }
 
-       if (init_attr->qp_type == IB_QPT_XRC_TGT) {
-               init_attr->recv_cq = NULL;
+       if (init_attr->qp_type == IB_QPT_XRC_TGT)
                xrcdn = to_mxrcd(init_attr->xrcd)->xrcdn;
-               init_attr->send_cq = NULL;
-       }
-
-       if (init_attr->qp_type == IB_QPT_XRC_INI)
-               init_attr->recv_cq = NULL;
 
        err = create_qp_common(dev, pd, init_attr, udata, qp);
        if (err) {