OSDN Git Service

iommu: fix initialization without 'add_device' callback
authorMarek Szyprowski <m.szyprowski@samsung.com>
Wed, 19 Nov 2014 11:15:31 +0000 (11:15 +0000)
committerDavid Keitel <dkeitel@codeaurora.org>
Tue, 22 Mar 2016 18:14:42 +0000 (11:14 -0700)
IOMMU drivers can be initialized from of_iommu helpers. Such drivers don't
need to provide device_add callbacks to operate properly, so there is no
need to fail initialization if the callback is missing.

Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
drivers/iommu/iommu.c

index eec0eda..0ee7a15 100644 (file)
@@ -740,7 +740,7 @@ static int add_iommu_group(struct device *dev, void *data)
        const struct iommu_ops *ops = cb->ops;
 
        if (!ops->add_device)
-               return -ENODEV;
+               return 0;
 
        WARN_ON(dev->iommu_group);