OSDN Git Service

brcmfmac: support repeated brcmf_fw_alloc_request() calls
authorRafał Miłecki <rafal@milecki.pl>
Tue, 26 Feb 2019 13:11:16 +0000 (14:11 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 4 Apr 2019 10:00:11 +0000 (13:00 +0300)
During a normal brcmfmac lifetime brcmf_fw_alloc_request() is called
once only during the probe. It's safe to assume provided array is clear.

Further brcmfmac improvements may require calling it multiple times
though. This patch allows it by fixing invalid firmware paths like:
brcm/brcmfmac4366c-pcie.binbrcm/brcmfmac4366c-pcie.bin

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c

index 8209a42..65098a0 100644 (file)
@@ -743,6 +743,7 @@ brcmf_fw_alloc_request(u32 chip, u32 chiprev,
 
        for (j = 0; j < n_fwnames; j++) {
                fwreq->items[j].path = fwnames[j].path;
+               fwnames[j].path[0] = '\0';
                /* check if firmware path is provided by module parameter */
                if (brcmf_mp_global.firmware_path[0] != '\0') {
                        strlcpy(fwnames[j].path, mp_path,