OSDN Git Service

scsi: hpsa: Fix configured_logical_drive_count·check
authorChristos Gkekas <chris.gekas@gmail.com>
Mon, 16 Oct 2017 19:28:02 +0000 (20:28 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 17 Oct 2017 03:14:31 +0000 (23:14 -0400)
Check whether configured_logical_drive_count is less than 255. Previous
check was always evaluating to true as this variable is defined as u8.

Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
Acked-by: Don Brace <don.brace@microsemi.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hpsa.c

index 9abe810..4ed3d26 100644 (file)
@@ -4091,7 +4091,7 @@ static int hpsa_set_local_logical_count(struct ctlr_info *h,
        memset(id_ctlr, 0, sizeof(*id_ctlr));
        rc = hpsa_bmic_id_controller(h, id_ctlr, sizeof(*id_ctlr));
        if (!rc)
-               if (id_ctlr->configured_logical_drive_count < 256)
+               if (id_ctlr->configured_logical_drive_count < 255)
                        *nlocals = id_ctlr->configured_logical_drive_count;
                else
                        *nlocals = le16_to_cpu(