OSDN Git Service

ASoC: rt5663: clarify expression
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 2 Mar 2021 21:25:18 +0000 (15:25 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:10:06 +0000 (13:10 +0000)
cppcheck warning:

bitwise operation. Clarify expression with
parentheses. [clarifyCondition]
  (pll_code.m_bp ? 0 : pll_code.m_code) << RT5663_PLL_M_SHIFT |
                                                              ^

sound/soc/codecs/rt5663.c:2955:63: style: Boolean result is used in
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210302212527.55158-16-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5663.c

index 619fb9a..be9fc58 100644 (file)
@@ -2952,8 +2952,8 @@ static int rt5663_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
        snd_soc_component_write(component, RT5663_PLL_1,
                pll_code.n_code << RT5663_PLL_N_SHIFT | pll_code.k_code);
        snd_soc_component_write(component, RT5663_PLL_2,
-               (pll_code.m_bp ? 0 : pll_code.m_code) << RT5663_PLL_M_SHIFT |
-               pll_code.m_bp << RT5663_PLL_M_BP_SHIFT);
+               ((pll_code.m_bp ? 0 : pll_code.m_code) << RT5663_PLL_M_SHIFT) |
+               (pll_code.m_bp << RT5663_PLL_M_BP_SHIFT));
 
        rt5663->pll_in = freq_in;
        rt5663->pll_out = freq_out;