IB/qedr: Remove GID add/del dummy routines

qedr driver's add_gid() and del_gid() callbacks are doing simple
checks which are already done by the ib core before invoking these
callback routines.

Therefore, code is simplified to skip implementing add_gid() and
del_gid() callback functions.

Signed-off-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c
index 2274d12..d3ed711 100644 (file)
--- a/drivers/infiniband/hw/qedr/main.c
+++ b/drivers/infiniband/hw/qedr/main.c
@@ -164,9 +164,6 @@ static void qedr_roce_register_device(struct qedr_dev *dev)
        dev->ibdev.node_type = RDMA_NODE_IB_CA;
        dev->ibdev.query_gid = qedr_query_gid;
 
-       dev->ibdev.add_gid = qedr_add_gid;
-       dev->ibdev.del_gid = qedr_del_gid;
-
        dev->ibdev.get_port_immutable = qedr_roce_port_immutable;
 }
 

diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c
index b61a395..8587a68 100644 (file)
--- a/drivers/infiniband/hw/qedr/verbs.c
+++ b/drivers/infiniband/hw/qedr/verbs.c
@@ -105,37 +105,6 @@ int qedr_query_gid(struct ib_device *ibdev, u8 port, int index,
        return rc;
 }
 
-int qedr_add_gid(struct ib_device *device, u8 port_num,
-                unsigned int index, const union ib_gid *gid,
-                const struct ib_gid_attr *attr, void **context)
-{
-       if (!rdma_cap_roce_gid_table(device, port_num))
-               return -EINVAL;
-
-       if (port_num > QEDR_MAX_PORT)
-               return -EINVAL;
-
-       if (!context)
-               return -EINVAL;
-
-       return 0;
-}
-
-int qedr_del_gid(struct ib_device *device, u8 port_num,
-                unsigned int index, void **context)
-{
-       if (!rdma_cap_roce_gid_table(device, port_num))
-               return -EINVAL;
-
-       if (port_num > QEDR_MAX_PORT)
-               return -EINVAL;
-
-       if (!context)
-               return -EINVAL;
-
-       return 0;
-}
-
 int qedr_query_device(struct ib_device *ibdev,
                      struct ib_device_attr *attr, struct ib_udata *udata)
 {

diff --git a/drivers/infiniband/hw/qedr/verbs.h b/drivers/infiniband/hw/qedr/verbs.h
index 1a94425..b533049 100644 (file)
--- a/drivers/infiniband/hw/qedr/verbs.h
+++ b/drivers/infiniband/hw/qedr/verbs.h
@@ -48,11 +48,6 @@ struct ib_ucontext *qedr_alloc_ucontext(struct ib_device *, struct ib_udata *);
 int qedr_dealloc_ucontext(struct ib_ucontext *);
 
 int qedr_mmap(struct ib_ucontext *, struct vm_area_struct *vma);
-int qedr_del_gid(struct ib_device *device, u8 port_num,
-                unsigned int index, void **context);
-int qedr_add_gid(struct ib_device *device, u8 port_num,
-                unsigned int index, const union ib_gid *gid,
-                const struct ib_gid_attr *attr, void **context);
 struct ib_pd *qedr_alloc_pd(struct ib_device *,
                            struct ib_ucontext *, struct ib_udata *);
 int qedr_dealloc_pd(struct ib_pd *pd);