OSDN Git Service

staging: qlge: qlge_ethtool: Remove one byte memset.
authorSuraj Upadhyay <usuraj35@gmail.com>
Mon, 13 Jul 2020 12:22:22 +0000 (17:52 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Jul 2020 13:37:47 +0000 (15:37 +0200)
Use direct assignment instead of using memset with just one byte as an
argument.
Issue found by checkpatch.pl.

Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
Link: https://lore.kernel.org/r/b5eb87576cef4bf1b968481d6341013e6c7e9650.1594642213.git.usuraj35@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/qlge/qlge_ethtool.c

index 16fcdef..d44b2da 100644 (file)
@@ -516,8 +516,8 @@ static void ql_create_lb_frame(struct sk_buff *skb,
        memset(skb->data, 0xFF, frame_size);
        frame_size &= ~1;
        memset(&skb->data[frame_size / 2], 0xAA, frame_size / 2 - 1);
-       memset(&skb->data[frame_size / 2 + 10], 0xBE, 1);
-       memset(&skb->data[frame_size / 2 + 12], 0xAF, 1);
+       skb->data[frame_size / 2 + 10] = (unsigned char)0xBE;
+       skb->data[frame_size / 2 + 12] = (unsigned char)0xAF;
 }
 
 void ql_check_lb_frame(struct ql_adapter *qdev,