OSDN Git Service

media: atomisp: avoid an extra memset() when alloc memory
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 28 May 2020 07:17:28 +0000 (09:17 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 11 Jun 2020 16:20:10 +0000 (18:20 +0200)
Use the variant which zeroes the memory when allocating,
instead of having an explicit memset.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c
drivers/staging/media/atomisp/pci/sh_css.c

index ebf36f7..feacd8f 100644 (file)
@@ -593,12 +593,11 @@ static enum ia_css_err pipeline_stage_create(
                out_frame[i] = stage_desc->out_frame[i];
        }
 
-       stage = kvmalloc(sizeof(*stage), GFP_KERNEL);
+       stage = kvzalloc(sizeof(*stage), GFP_KERNEL);
        if (!stage) {
                err = IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY;
                goto ERR;
        }
-       memset(stage, 0, sizeof(*stage));
 
        if (firmware) {
                stage->binary = NULL;
index 35093c5..fccba2a 100644 (file)
@@ -9400,7 +9400,7 @@ ia_css_stream_create(const struct ia_css_stream_config *stream_config,
        }
 
        /* allocate the stream instance */
-       curr_stream = kmalloc(sizeof(struct ia_css_stream), GFP_KERNEL);
+       curr_stream = kzalloc(sizeof(struct ia_css_stream), GFP_KERNEL);
        if (!curr_stream)
        {
                err = IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY;
@@ -9408,7 +9408,6 @@ ia_css_stream_create(const struct ia_css_stream_config *stream_config,
                return err;
        }
        /* default all to 0 */
-       memset(curr_stream, 0, sizeof(struct ia_css_stream));
        curr_stream->info.metadata_info = md_info;
 
        /* allocate pipes */