OSDN Git Service

scsi: bnx2fc: Fix comparison to bool warning
authorKaixu Xia <kaixuxia@tencent.com>
Sat, 7 Nov 2020 16:52:00 +0000 (00:52 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 11 Nov 2020 04:09:43 +0000 (23:09 -0500)
Fix the following coccicheck warning:

./drivers/scsi/bnx2fc/bnx2fc_fcoe.c:2089:5-23: WARNING: Comparison to bool
./drivers/scsi/bnx2fc/bnx2fc_fcoe.c:2187:5-23: WARNING: Comparison to bool

Link: https://lore.kernel.org/r/1604767920-8361-1-git-send-email-kaixuxia@tencent.com
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Acked-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/bnx2fc/bnx2fc_fcoe.c

index a436adb..52bd0db 100644 (file)
@@ -2086,7 +2086,7 @@ static int __bnx2fc_disable(struct fcoe_ctlr *ctlr)
 {
        struct bnx2fc_interface *interface = fcoe_ctlr_priv(ctlr);
 
-       if (interface->enabled == true) {
+       if (interface->enabled) {
                if (!ctlr->lp) {
                        pr_err(PFX "__bnx2fc_disable: lport not found\n");
                        return -ENODEV;
@@ -2184,7 +2184,7 @@ static int __bnx2fc_enable(struct fcoe_ctlr *ctlr)
        struct cnic_fc_npiv_tbl *npiv_tbl;
        struct fc_lport *lport;
 
-       if (interface->enabled == false) {
+       if (!interface->enabled) {
                if (!ctlr->lp) {
                        pr_err(PFX "__bnx2fc_enable: lport not found\n");
                        return -ENODEV;