OSDN Git Service

iio: accel: use strlcpy() instead of strncpy()
authorXiongfeng Wang <xiongfeng.wang@linaro.org>
Fri, 12 Jan 2018 07:45:38 +0000 (15:45 +0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 30 Jan 2018 18:33:14 +0000 (18:33 +0000)
gcc-8 reports

drivers/iio/accel/st_accel_i2c.c: In function 'st_accel_i2c_probe':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 20 equals destination size [-Wstringop-truncation]

The compiler require that the length of the dest string is greater than
the length we want to copy to make sure the dest string is
nul-terminated. We can just use strlcpy() to avoid this warning.

Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/accel/st_accel_i2c.c

index 363429b..6bdec8c 100644 (file)
@@ -159,9 +159,8 @@ static int st_accel_i2c_probe(struct i2c_client *client,
                if ((ret < 0) || (ret >= ST_ACCEL_MAX))
                        return -ENODEV;
 
-               strncpy(client->name, st_accel_id_table[ret].name,
+               strlcpy(client->name, st_accel_id_table[ret].name,
                                sizeof(client->name));
-               client->name[sizeof(client->name) - 1] = '\0';
        } else if (!id)
                return -ENODEV;