OSDN Git Service

net: macb: Remove redundant poll irq assignment
authorBrad Mouring <brad.mouring@ni.com>
Tue, 13 Mar 2018 21:32:14 +0000 (16:32 -0500)
committerDavid S. Miller <davem@davemloft.net>
Fri, 16 Mar 2018 15:14:33 +0000 (11:14 -0400)
In phy_device's general probe, this device will already be set for
phy register polling, rendering this code redundant.

Signed-off-by: Brad Mouring <brad.mouring@ni.com>
Suggested-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cadence/macb_main.c

index 4b514c7..db1dc30 100644 (file)
@@ -566,7 +566,7 @@ static int macb_mii_init(struct macb *bp)
 {
        struct macb_platform_data *pdata;
        struct device_node *np;
-       int err, i;
+       int err;
 
        /* Enable management port */
        macb_writel(bp, NCR, MACB_BIT(MPE));
@@ -593,9 +593,6 @@ static int macb_mii_init(struct macb *bp)
        if (np) {
                err = of_mdiobus_register(bp->mii_bus, np);
        } else {
-               for (i = 0; i < PHY_MAX_ADDR; i++)
-                       bp->mii_bus->irq[i] = PHY_POLL;
-
                if (pdata)
                        bp->mii_bus->phy_mask = pdata->phy_mask;