OSDN Git Service

phy: ti: tusb1210: Drop tusb->vendor_specific2 != 0 check from tusb1210_power_on()
authorHans de Goede <hdegoede@redhat.com>
Sun, 13 Feb 2022 13:05:22 +0000 (14:05 +0100)
committerVinod Koul <vkoul@kernel.org>
Fri, 25 Feb 2022 08:58:07 +0000 (14:28 +0530)
Since commit eb445a15fa69 ("phy: tusb1210: use bitmasks to set
VENDOR_SPECIFIC2") tusb->vendor_specific2 always contains a valid value
so there no need to check that it is set.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20220213130524.18748-8-hdegoede@redhat.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/ti/phy-tusb1210.c

index bf7793a..04baed2 100644 (file)
@@ -61,11 +61,8 @@ static int tusb1210_power_on(struct phy *phy)
        gpiod_set_value_cansleep(tusb->gpio_cs, 1);
 
        /* Restore the optional eye diagram optimization value */
-       if (tusb->vendor_specific2)
-               return tusb1210_ulpi_write(tusb, TUSB1210_VENDOR_SPECIFIC2,
-                                          tusb->vendor_specific2);
-
-       return 0;
+       return tusb1210_ulpi_write(tusb, TUSB1210_VENDOR_SPECIFIC2,
+                                  tusb->vendor_specific2);
 }
 
 static int tusb1210_power_off(struct phy *phy)